fix: TUI spawn: reset BUN_OPTIONS #3606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veracioux
changed the title
veracioux
force-pushed
the
fix/tui-spawn-reset-bun-options
branch
from
ff9a562 to
fe08a35
Compare
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often do something like
export BUN_OPTIONS='--inspect-wait=localhost:6499/'before runningbun dev.In the opentui branch, I usually use
bun dev spawnso I can get working debugger endpoints inserver.ts. Before this fix, theattachsubprocess spawned bybun dev spawnwould inheritBUN_OPTIONS, causing a port conflict.Even as a more general principle, I think we shouldn't blindly pass
BUN_OPTIONSto subprocesses.